Merged
Conversation
donnie-msft
approved these changes
Aug 26, 2025
donnie-msft
left a comment
Contributor
There was a problem hiding this comment.
Looks functionally equivalent to me, so if it resolves the bug, I agree with your assessment to take this for now.
jebriede
approved these changes
Aug 26, 2025
zivkan
approved these changes
Aug 26, 2025
martinrrm
approved these changes
Aug 26, 2025
jebriede
pushed a commit
that referenced
this pull request
Aug 28, 2025
3 tasks
jebriede
pushed a commit
that referenced
this pull request
Aug 28, 2025
jebriede
added a commit
that referenced
this pull request
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14504
Description
We have a little bit of an ordering problem here.
In the single tfm case, none of the conditions we based on framework seem to apply and the root cause seems to be the fact that we play around with setting and unsetting
TargetFrameworkandTargetFrameworks.I'm not thrilled with this fix, we need to clean-up more of our infra, but this is good enough for now.
After this change, NuGet.PackageManagement.UI and the likes are actually generating a
.prereleasenum versions which is what we wanted originally in https://github.com/dotnet/dotnet/pull/1881/filesThese are the local version numbers:
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.