Add Source URL Validation to Package Sources page - #6730
#6730Merged
donnie-msft merged 8 commits intoAug 20, 2025
devNuGet/NuGet.Client:devfrom
dev-donnie-msft-usxSourceValNuGet/NuGet.Client:dev-donnie-msft-usxSourceValCopy head branch name to clipboard
Merged
Add Source URL Validation to Package Sources page#6730donnie-msft merged 8 commits intodevNuGet/NuGet.Client:devfrom dev-donnie-msft-usxSourceValNuGet/NuGet.Client:dev-donnie-msft-usxSourceValCopy head branch name to clipboard
donnie-msft merged 8 commits into
devNuGet/NuGet.Client:devfrom
dev-donnie-msft-usxSourceValNuGet/NuGet.Client:dev-donnie-msft-usxSourceValCopy head branch name to clipboard
Conversation
zivkan
previously approved these changes
Aug 20, 2025
zivkan
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14359
Fixes: https://github.com/NuGet/Client.Engineering/issues/3385
Description
Implements the Unified Settings validation API
IExternalSettingValidatorfor array item settings on the Package Sources page.Pressing "Save" with an invalid source would result in a permanent error on the Package Sources page, resolved only by VS Restart.
Now, a blocking error message is shown on the dialog:
Example 1:
Example 2:
Change details
PR Checklist
Added testsTested manually and this code is invoking an already tested Validator class. Let me know if anyone feels another test would be useful.