fix(release): make promotion atomic#340
fix(release): make promotion atomic#340NikolayS wants to merge 7 commits intoagent/fix-tle-upgradeNikolayS/PgQue:agent/fix-tle-upgradefrom agent/fix-release-promotionNikolayS/PgQue:agent/fix-release-promotionCopy head branch name to clipboard
Conversation
NikolayS
left a comment
There was a problem hiding this comment.
REV rubric review
This is a manual execution of the repository's five applicable REV rubrics because the automated ultrareview quota was unavailable. It is not bot output. SOC2 was omitted as required.
- Bug hunter: promotion staging, verification, rollback, and devel restoration are fail-closed; no additional high-confidence defect found.
- Security reviewer: scripts use strict mode/IFS, quoted paths, isolated staging, and checksum/version coherence; no command-injection or credential finding.
- Test analyzer: failure, partial, stale, isolation, Postgres, and integration paths are broad; CI is 17/17 green. Initial implementation/tests are retrospective rather than chronological RED.
- Docs reviewer: RELEASE.md is appropriately release-specific and the checklist makes unproduced final artifacts explicit.
- Guidelines checker: shellcheck is clean, but history contains unsupported repo-specific
release:,test:, andci:types; one docs subject is 54 characters. The PR title also differs from the mainrelease:subject.
Blocking merge-order constraint: this PR is based on #333 and states that #342 supplies the documentation contract. #342 is itself stacked on #339. Do not merge or execute final promotion until #333 and the #339 → #342 documentation stack have landed or this branch has been synchronized and the combined checks rerun.
Nonblocking/history: preserve published history and use a compliant repo-specific squash/merge subject. A real-user promotion evidence comment remains required. This COMMENT review is not an approval.
Real-user verification evidenceVerified exact head Chronological RED to GREEN: git checkout 7ae1883
bash tests/test_release_promotion.sh
git checkout 1b4ba4c
bash tests/test_release_promotion.sh
bash -n \
build/promote-release.sh \
build/read-version.sh \
build/verify-release-artifacts.sh \
tests/test_release_promotion.sh
shellcheck \
build/promote-release.sh \
build/read-version.sh \
build/verify-release-artifacts.sh \
tests/test_release_promotion.shRED output: The GREEN promotion suite passed promotion, repeated transformation, restore, I also exercised the maintainer path in a disposable copy with fresh bash build/promote-release.sh 0.3.0
bash build/verify-release-artifacts.sh
export PAGER=cat
psql --no-psqlrc --set=ON_ERROR_STOP=1 \
--dbname="$PGQUE_TEST_DSN" --file=sql/pgque.sql
psql --no-psqlrc --set=ON_ERROR_STOP=1 \
--dbname="$PGQUE_TEST_DSN" --file=tests/run_all.sql
psql --no-psqlrc --set=ON_ERROR_STOP=1 \
--dbname="$PGQUE_TEST_DSN" --file=tests/acceptance/run_acceptance.sql
psql --no-psqlrc --set=ON_ERROR_STOP=1 \
--dbname="$PGQUE_TEST_DSN" --file=sql/pgque_uninstall.sqlKey output: Full CI run 29155476659 passed on this exact head. Merge-order gate: #342 must |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Added a docs-only follow-up (
Also added one line to the release-notes checklist ("Tag and publish") requiring the notes to document the devel-channel pg_tle case (a db registered at |
Summary
Fixes #325.
Stack
agent/fix-tle-upgrade)Validation
git diff --checkpassedThe final promoted bytes do not exist yet, so the checklist keeps the supported-PG stable matrix, stateful v0.2 upgrade, final stable pg_tle fresh/update paths, both uninstalls, reviewed release notes, and documentation-channel promotion as mandatory pre-tag gates. #333 supplies continuous real pg_tle update coverage.