fix(python): derive runtime version from metadata#332
Conversation
|
Real-user verification evidence The original RED is retrospective because implementation and tests were committed together. Loading the final version tests with the base package failed collection with Supported-runtime package path: docker run --rm -v "$PWD/clients/python:/src:ro" -w /tmp python:3.13-slim sh -c '
set -eu
cp -R /src /tmp/pkg && cd /tmp/pkg
python -m pip install ".[dev]" build
PGQUE_TEST_DSN=postgresql://nik@host.docker.internal/pgque_pr_rules_audit python -m pytest -q
python -m build
python -m pip install --force-reinstall dist/*.whl
cd /tmp && python -c "import pgque; assert pgque.__version__ == \"0.2.0\""
'Result: 80 passed; sdist and wheel built; installed-wheel runtime metadata was The branch |
NikolayS
left a comment
There was a problem hiding this comment.
REV rubric review
Automated ultrareview quota was unavailable, so I executed the five official
REV rubric prompts manually. SOC2 findings were omitted as instructed. This is
a comment-only review, not an approval.
Blocking findings
None. I found no unresolved functional, security, documentation, or test
blocker on head 423a76e157e45e35a92aeda32f010c2e83e467f2.
Rubric results
- Bug hunter: installed distribution metadata is authoritative; an unpackaged
source tree falls back to the[project]version and has an explicit unknown
result when source metadata is absent. - Security reviewer: the parser does not evaluate project content, and publish
jobs remain gated bydry_run, repository choice, environments, and OIDC. - Docs reviewer: the single-source version contract and dry-run validation
path are documented accurately. - Guidelines checker: all current commits use allowed types, subjects are
under 50 characters, the test-first dry-run correction is chronological,
and all 17 CI checks pass. - Test analyzer: source, editable, wheel metadata, isolated wheel install, and
branch dry-run/publish exclusions are covered. Exact-head workflow dispatch
run 29156149467 passed; both PyPI publishers were correctly skipped.
Nonblocking findings
The original version fix has retrospective RED evidence because implementation
and tests share a commit; this is disclosed in the evidence comment and cannot
be reordered without rewriting history. No current change is requested.
Summary
pgque-pymetadata authoritative forpgque.__version__pyproject.tomlfor direct checkout importsFixes #326.
Validation
10 passed, 70 skipped(DB-gated)twine checkpassed for wheel and sdistactionlint, YAML parsing, andgit diff --checkpassed