build: declare dependency to use it as subproject#1451
Open
ylatuya wants to merge 1 commit into
Open
build: declare dependency to use it as subproject#1451ylatuya wants to merge 1 commit into
ylatuya wants to merge 1 commit into
Conversation
ylatuya
force-pushed
the
vmaf_dep
branch
3 times, most recently
from
December 2, 2025 15:02
c93a3c6 to
3446ff8
Compare
xclaesse
reviewed
Dec 4, 2025
Declare the libvmaf_dep dependency so that libvmaf can be used as a subproject.
Contributor
Author
|
Any chance of getting this merged? It's not possible to build libvmaf as a subproject without this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the work we are doing to add a new vmaf element in GStreamer, we are also adding vmaf as a subproject of GStreamer. In #1442 we fixed a linker issue with symbol names when building as a subproject.
In this PR we declare the
libvmaf_depdependency following https://mesonbuild.com/Subprojects.html#naming-convention-for-dependency-variables so that it can be used from other projects like:One remaining issue is the lack of a
meson.buildin the repository root directory, for which I will open a new PR.