Rename FunctionField to AbsSimpleFunctionField#2416
Merged
thofma merged 2 commits intoJun 8, 2026
Nemocas:masterNemocas/AbstractAlgebra.jl:masterfrom
alexey-orlov-math:funfield-rename-abssimplealexey-orlov-math/AbstractAlgebra.jl:funfield-rename-abssimpleCopy head branch name to clipboard
Merged
Rename FunctionField to AbsSimpleFunctionField#2416thofma merged 2 commits intoNemocas:masterNemocas/AbstractAlgebra.jl:masterfrom alexey-orlov-math:funfield-rename-abssimplealexey-orlov-math/AbstractAlgebra.jl:funfield-rename-abssimpleCopy head branch name to clipboard
thofma merged 2 commits into
Nemocas:masterNemocas/AbstractAlgebra.jl:masterfrom
alexey-orlov-math:funfield-rename-abssimplealexey-orlov-math/AbstractAlgebra.jl:funfield-rename-abssimpleCopy head branch name to clipboard
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2416 +/- ##
==========================================
- Coverage 88.12% 88.12% -0.01%
==========================================
Files 130 130
Lines 32972 32972
==========================================
- Hits 29058 29057 -1
- Misses 3914 3915 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lgoettgens
reviewed
Jun 8, 2026
Member
|
Sorry, there are now merge conflicts because of #2414 |
Rename both Generic.FunctionField to Generic.AbsSimpleFunctionField, and Generic.FunctionFieldElem to Generic.AbsSimpleFunctionFieldElem; also rename internal cache dict for function fields. Add const aliases inside `Generic` module. The `function_field` constructor and file names are unchanged. Also renamed "Generic.FunctionField.conformance" testset to "Generic.RationalFunctionField.conformance" as it tests conformance of RationalFunctionField exactly
alexey-orlov-math
force-pushed
the
funfield-rename-abssimple
branch
from
June 8, 2026 19:18
fe4bb50 to
df36c36
Compare
Contributor
Author
I have rebased and force pushed (rewriting history). Should be a clean merge now (but maybe let's wait for non-hecke tests to become green) |
thofma
referenced
this pull request
Jun 9, 2026
Co-authored-by: changelog[bot] <changelog[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename both Generic.FunctionField to Generic.AbsSimpleFunctionField, and Generic.FunctionFieldElem to Generic.AbsSimpleFunctionFieldElem; also rename internal cache dict for function fields. Add const aliases inside
Genericmodule. Thefunction_fieldconstructor and file names are unchanged.Also renamed "Generic.FunctionField.conformance" testset to "Generic.RationalFunctionField.conformance" as it tests conformance of RationalFunctionField exactly