Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Disable Julia fallbacks for iszero/isone for our parent objects#2305

Merged
lgoettgens merged 2 commits into
masterNemocas/AbstractAlgebra.jl:masterfrom
mh/block-iszero-isone-for-SetNemocas/AbstractAlgebra.jl:mh/block-iszero-isone-for-SetCopy head branch name to clipboard
Jan 22, 2026
Merged

Disable Julia fallbacks for iszero/isone for our parent objects#2305
lgoettgens merged 2 commits into
masterNemocas/AbstractAlgebra.jl:masterfrom
mh/block-iszero-isone-for-SetNemocas/AbstractAlgebra.jl:mh/block-iszero-isone-for-SetCopy head branch name to clipboard

Conversation

@fingolfin

Copy link
Copy Markdown
Member

No description provided.

@fingolfin
fingolfin requested a review from lgoettgens January 17, 2026 01:04
@codecov

codecov Bot commented Jan 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.22%. Comparing base (b548c14) to head (b5013ad).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/AbstractAlgebra.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
- Coverage   88.22%   88.22%   -0.01%     
==========================================
  Files         126      126              
  Lines       32000    32002       +2     
==========================================
  Hits        28233    28233              
- Misses       3767     3769       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens lgoettgens changed the title Disable Julia fallbacks for iszero/isone for our parent objects Disable Julia fallbacks for iszero/isone for our parent objects Jan 21, 2026
@lgoettgens lgoettgens added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes enhancement New feature or request bug: wrong result Bugs that returned incorrect results and removed enhancement New feature or request labels Jan 22, 2026
@lgoettgens
lgoettgens merged commit 176f4e3 into master Jan 22, 2026
21 of 23 checks passed
@lgoettgens
lgoettgens deleted the mh/block-iszero-isone-for-Set branch January 22, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: wrong result Bugs that returned incorrect results release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.