Add ^(I::Ideal, k::Integer) fallback method#2279
Merged
Merged
Add ^(I::Ideal, k::Integer) fallback method#2279
^(I::Ideal, k::Integer) fallback method#2279Conversation
Also implement ideal, ideal_type for Integers and univariate polynomial rings over fields, so that we can have some tests of this generic method.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2279 +/- ##
=======================================
Coverage 88.22% 88.23%
=======================================
Files 126 126
Lines 31800 31817 +17
=======================================
+ Hits 28057 28075 +18
+ Misses 3743 3742 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lgoettgens
approved these changes
Jan 9, 2026
Merged
fingolfin
referenced
this pull request
Jan 9, 2026
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also implement
ideal,ideal_typefor integers and univariate polynomial rings over fields, so that we can have some tests for the new^method.I wrote this well over a month ago but then forgot to submit it after my previous "ideal" PRs got merged :-(
(It would be nice to have because we can then remove more code in OSCAR and possible Hecke, but since it should be non-breaking, it could also come later)