Conversation
Based on Nemo's test/HeckeMiscLocalization-test.jl
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2254 +/- ##
==========================================
+ Coverage 88.07% 88.46% +0.38%
==========================================
Files 126 126
Lines 31728 31994 +266
==========================================
+ Hits 27946 28305 +359
+ Misses 3782 3689 -93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
lgoettgens
approved these changes
Dec 17, 2025
lgoettgens
enabled auto-merge (squash)
December 17, 2025 14:19
fingolfin
disabled auto-merge
December 22, 2025 23:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Nemo's
test/HeckeMiscLocalization-test.jlAs always (?), running conformance tests revealed a genuine bug (this time in
is_unit(::LocalizedEuclideanRingElem)