fix(tab-view): remove onBackPressed override#6755
Merged
ADjenkov merged 1 commit intoJan 4, 2019
masterNativeScript/NativeScript:masterfrom
djenkov/tab-view-frameNativeScript/NativeScript:djenkov/tab-view-frameCopy head branch name to clipboard
Merged
fix(tab-view): remove onBackPressed override#6755ADjenkov merged 1 commit intomasterNativeScript/NativeScript:masterfrom djenkov/tab-view-frameNativeScript/NativeScript:djenkov/tab-view-frameCopy head branch name to clipboard
ADjenkov merged 1 commit into
masterNativeScript/NativeScript:masterfrom
djenkov/tab-view-frameNativeScript/NativeScript:djenkov/tab-view-frameCopy head branch name to clipboard
Conversation
Contributor
Author
|
test ngapps |
Contributor
|
test --ignore templates api23 ios12 |
manoldonev
approved these changes
Jan 4, 2019
SvetoslavTsenov
pushed a commit
that referenced
this pull request
Jan 15, 2019
SvetoslavTsenov
added a commit
that referenced
this pull request
Jan 15, 2019
…ase-5.1.2 fix(tab-view): remove onBackPressed override (#6755)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android back button will exit the app, instead going back to previous list page, when using lazy loaded nested named inside TabViewItems.
This happens only if using as a root component (template-tab-navigation-ng template).
Remove onBackPressed override, since the topmost() frame is now properly assigned when switching between tab view items.
Fix NativeScript/nativescript-angular#1680