refactor: Application barrel changes without breaking changes #10311
Conversation
☁️ Nx Cloud ReportAttention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here. CI is running/has finished running commands for commit cf8b328. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
Note, this introduces a breaking change to the The original thinking was that since we’re introducing a breaking change in either case, we should go with the “cleaner” version, which I thought was the getter one. Though looking at usage, the Given last point, let's just make sure this PR addresses all core usage of |
There was a problem hiding this comment.
Given changes, a few more places need to be updated:
Application.android.orientation -> Application.android.orientation()Application.android.systemAppearance -> Application.android.systemAppearance()Application.ios.orientation -> Application.ios.orientation()Application.ios.systemAppearance -> Application.ios.systemAppearance()Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
This reverts commit cf644b9.
PR Checklist
What is the current behavior?
f64355b introduces breaking changes to 2 APIs on Application class,
orientationas a getter only andsystemAppearanceas a getter only.What is the new behavior?
This allows the barrel refactor to proceed without breaking changes, maintaining existing behavior of
Application.orientation()as a function andApplication.systemAppearance()as a function.