Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ab5fa94

Browse filesBrowse files
authored
refactor: Application barrel changes without breaking changes (#10311)
1 parent 0956cb0 commit ab5fa94
Copy full SHA for ab5fa94

File tree

4 files changed

+55
-55
lines changed
Filter options

4 files changed

+55
-55
lines changed

‎apps/automated/src/application/application-tests.android.ts

Copy file name to clipboardExpand all lines: apps/automated/src/application/application-tests.android.ts
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* tslint:disable:no-unused-variable */
2-
import { Application } from '@nativescript/core';
2+
import { Application, Utils } from '@nativescript/core';
33
import * as TKUnit from '../tk-unit';
44

55
export * from './application-tests-common';
@@ -47,11 +47,11 @@ export function testAndroidApplicationInitialized() {
4747
);
4848
TKUnit.assert(Application.android.startActivity, 'Android startActivity not initialized.');
4949
TKUnit.assert(Application.android.nativeApp, 'Android nativeApp not initialized.');
50-
TKUnit.assert(Application.android.orientation, 'Android orientation not initialized.');
51-
TKUnit.assert(Application.android.packageName, 'Android packageName not initialized.');
52-
TKUnit.assert(Application.android.systemAppearance, 'Android system appearance not initialized.');
50+
TKUnit.assert(Application.android.orientation(), 'Android orientation not initialized.');
51+
TKUnit.assert(Utils.android.getPackageName(), 'Android packageName not initialized.');
52+
TKUnit.assert(Application.android.systemAppearance(), 'Android system appearance not initialized.');
5353
}
5454

5555
export function testSystemAppearance() {
56-
TKUnit.assert(Application.android.systemAppearance, 'System appearance not initialized.');
56+
TKUnit.assert(Application.android.systemAppearance(), 'System appearance not initialized.');
5757
}

‎apps/automated/src/application/application-tests.ios.ts

Copy file name to clipboardExpand all lines: apps/automated/src/application/application-tests.ios.ts
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@ export function testIOSApplicationInitialized() {
4444
TKUnit.assert(Application.ios, 'iOS application not initialized.');
4545
TKUnit.assert(Application.ios.delegate, 'iOS delegate not initialized.');
4646
TKUnit.assert(Application.ios.nativeApp, 'iOS nativeApp not initialized.');
47-
TKUnit.assert(Application.ios.orientation, 'iOS orientation not initialized.');
47+
TKUnit.assert(Application.ios.orientation(), 'iOS orientation not initialized.');
4848

4949
if (Utils.ios.MajorVersion <= 11) {
50-
TKUnit.assertNull(Application.ios.systemAppearance, 'iOS system appearance should be `null` on iOS <= 11.');
50+
TKUnit.assertNull(Application.ios.systemAppearance(), 'iOS system appearance should be `null` on iOS <= 11.');
5151
} else {
52-
TKUnit.assert(Application.ios.systemAppearance, 'iOS system appearance not initialized.');
52+
TKUnit.assert(Application.ios.systemAppearance(), 'iOS system appearance not initialized.');
5353
}
5454

5555
TKUnit.assert(Application.ios.window, 'iOS window not initialized.');
@@ -58,8 +58,8 @@ export function testIOSApplicationInitialized() {
5858

5959
export function testSystemAppearance() {
6060
if (Utils.ios.MajorVersion <= 11) {
61-
TKUnit.assertNull(Application.ios.systemAppearance, 'System appearance should be `null` on iOS <= 11.');
61+
TKUnit.assertNull(Application.ios.systemAppearance(), 'System appearance should be `null` on iOS <= 11.');
6262
} else {
63-
TKUnit.assert(Application.ios.systemAppearance, 'System appearance not initialized.');
63+
TKUnit.assert(Application.ios.systemAppearance(), 'System appearance not initialized.');
6464
}
6565
}

‎packages/core/application/application-common.ts

Copy file name to clipboardExpand all lines: packages/core/application/application-common.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ export class ApplicationCommon {
438438
});
439439
}
440440

441-
get orientation(): 'portrait' | 'landscape' | 'unknown' {
441+
orientation(): 'portrait' | 'landscape' | 'unknown' {
442442
return (this._orientation ??= this.getOrientation());
443443
}
444444

@@ -487,7 +487,7 @@ export class ApplicationCommon {
487487
});
488488
}
489489

490-
get systemAppearance(): 'dark' | 'light' | null {
490+
systemAppearance(): 'dark' | 'light' | null {
491491
// return cached value, or get it from the platform specific override
492492
return (this._systemAppearance ??= this.getSystemAppearance());
493493
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.