Blog plugin #463
Open
terry-cao wants to merge 9 commits into
Open
Blog plugin #463terry-cao wants to merge 9 commits into
terry-cao wants to merge 9 commits into
Conversation
yandthj
requested changes
Aug 25, 2023
yandthj
left a comment
Collaborator
There was a problem hiding this comment.
Functions, but some changes still required:
- When I click on a post, the author icon doesn't render properly on post's page on the left
- Author icon also doesn't render properly when I click on an individual year in the Archive
- The "Categories" tab navigates back to documentation home page.
yandthj
requested changes
Aug 30, 2023
yandthj
previously approved these changes
Aug 31, 2023
yandthj
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, will hold merging in until demo at working group meeting
terry-cao
dismissed
yandthj’s stale review
August 31, 2023 15:35
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.