Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ConfigurationItemFactory - Marked ParseMessageTemplates as obsolete#6187

Open
snakefoot wants to merge 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:ParseMessageTemplatesFactorysnakefoot/NLog:ParseMessageTemplatesFactoryCopy head branch name to clipboard
Open

ConfigurationItemFactory - Marked ParseMessageTemplates as obsolete#6187
snakefoot wants to merge 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:ParseMessageTemplatesFactorysnakefoot/NLog:ParseMessageTemplatesFactoryCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented May 24, 2026

Copy link
Copy Markdown
Contributor
  • Wait for NLog v6.2

@snakefoot snakefoot added the breaking behavior change Same API, different result label May 24, 2026
@coderabbitai

coderabbitai Bot commented May 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b24504c6-6815-4497-9fe4-1a60b33feec1

📥 Commits

Reviewing files that changed from the base of the PR and between a69890f and 91c9c16.

📒 Files selected for processing (1)
  • src/NLog/Config/ConfigurationItemFactory.cs

Walkthrough

This PR marks the private _serviceRepository field as obsolete for backward-compatibility tracking and handles the resulting compiler warnings through pragma directives in the constructor. XML documentation formatting around the ParseMessageTemplates property is also adjusted.

Changes

Obsolete Members and Warning Management

Layer / File(s) Summary
Obsolete field marking and warning suppression
src/NLog/Config/ConfigurationItemFactory.cs		 The _serviceRepository field is marked [Obsolete]. The constructor's assignment to this field is wrapped with CS0618 pragma directives to suppress warnings. XML documentation spacing around the ParseMessageTemplates obsolete property is adjusted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A field retires with grace, marked old and wise,
Pragmas shield the warnings from compiler's eyes,
Backward paths preserved in obsolete design,
Documentation dusted, everything in line! 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: marking ParseMessageTemplates as obsolete in ConfigurationItemFactory.
Description check ✅ Passed The description is minimal but related to the changeset, mentioning the wait for NLog v6.2 which contextualizes the obsolescence marking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@snakefoot snakefoot mentioned this pull request May 24, 2026
Open
@sonarqubecloud

sonarqubecloud Bot commented May 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@snakefoot snakefoot added this to the 6.2 milestone Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking behavior change Same API, different result size/XS

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

1 participant

@snakefoot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.