Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

JsonLayout - Refactor code to simplify rendering of scope properties - #5599

#5599
Merged
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:JsonLayoutScopesnakefoot/NLog:JsonLayoutScopeCopy head branch name to clipboard
Sep 11, 2024
Merged

JsonLayout - Refactor code to simplify rendering of scope properties#5599
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:JsonLayoutScopesnakefoot/NLog:JsonLayoutScopeCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Sep 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Maybe also consider optimizing this logic:

            if (beginJsonMessage)
            {
                if (IndentJson)
                    sb.Append('{').AppendLine().Append(' ', SpacesPerIndent).Append('"');
                else
                    sb.Append(SuppressSpaces ? "{\"" : "{ \"");
            }
            else
            {
                if (IndentJson)
                    sb.Append(',').AppendLine().Append(' ', SpacesPerIndent).Append('"');
                else
                    sb.Append(SuppressSpaces ? ",\"" : ", \"");
            }

@snakefoot snakefoot added this to the 5.3.4 milestone Sep 11, 2024
@snakefoot
snakefoot enabled auto-merge (squash) September 11, 2024 19:39
@sonarqubecloud

sonarqubecloud Bot commented Sep 11, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@snakefoot
snakefoot merged commit 3dec61f into NLog:dev Sep 11, 2024
@dependabot dependabot Bot mentioned this pull request Aug 1, 2025
Open
This was referenced Aug 26, 2025
Merged
Closed
@dependabot dependabot Bot mentioned this pull request Oct 1, 2025
Open
@dependabot dependabot Bot mentioned this pull request Nov 12, 2025
Merged
This was referenced Dec 8, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Dec 28, 2025
Merged
This was referenced Jan 7, 2026
Closed
Closed
Closed
Closed
This was referenced Jan 27, 2026
Closed
Merged
Closed
This was referenced Apr 6, 2026
Closed
Open
This was referenced Apr 22, 2026
Closed
Closed
Open
Merged
Open
@dependabot dependabot Bot mentioned this pull request May 4, 2026
Open
This was referenced May 25, 2026
Merged
Merged
Open
@dependabot dependabot Bot mentioned this pull request Jun 2, 2026
Closed
This was referenced Jun 14, 2026
Closed
Closed
Closed
This was referenced Jul 6, 2026
Merged
Closed
@dependabot dependabot Bot mentioned this pull request Jul 17, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jul 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

json / json-layout refactoring size/M

Projects

None yet

Milestone

5.3.4

Development

Successfully merging this pull request may close these issues.

1 participant

@snakefoot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.