InternalLogger - Obsoleted API to reduce dependencies - #5443
#5443Merged
snakefoot merged 2 commits intoMar 30, 2024
NLog:devNLog/NLog:devfrom
snakefoot:internallogger-obsoletesnakefoot/NLog:internallogger-obsoleteCopy head branch name to clipboard
Merged
InternalLogger - Obsoleted API to reduce dependencies#5443snakefoot merged 2 commits intoNLog:devNLog/NLog:devfrom snakefoot:internallogger-obsoletesnakefoot/NLog:internallogger-obsoleteCopy head branch name to clipboard
snakefoot merged 2 commits into
NLog:devNLog/NLog:devfrom
snakefoot:internallogger-obsoletesnakefoot/NLog:internallogger-obsoleteCopy head branch name to clipboard
Conversation
snakefoot
force-pushed
the
internallogger-obsolete
branch
12 times, most recently
from
December 22, 2023 08:27
98e6d25 to
18cce0a
Compare
Contributor
Author
|
This might not be the best name, as some might think this will be triggered for all LogEvents produced by the application: |
snakefoot
force-pushed
the
internallogger-obsolete
branch
3 times, most recently
from
January 2, 2024 21:10
1bb4add to
8cd1064
Compare
|
snakefoot
force-pushed
the
internallogger-obsolete
branch
from
March 16, 2024 09:20
8cd1064 to
3831991
Compare
snakefoot
force-pushed
the
internallogger-obsolete
branch
3 times, most recently
from
March 24, 2024 13:24
b297d88 to
0db4151
Compare
snakefoot
force-pushed
the
internallogger-obsolete
branch
from
March 24, 2024 13:25
0db4151 to
ac2d4b6
Compare
This was referenced Aug 26, 2025
This was referenced Dec 8, 2025
This was referenced Jan 7, 2026
This was referenced Jan 27, 2026
This was referenced Apr 22, 2026
This was referenced May 29, 2026
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like LogFactory should be platform-independent (Not require console or filesystem), then the same goes for InternalLogger.
Seems it is enough to just disconnect InternalLogger from the actual console- and file-writing (changed to subscription-logic). So now it is only when directly using
LogToConsole- orLogFile-property, that the penalty comes.