FileTarget - Removed explicit File.Create to not trigger file-scanners - #5381
#5381Merged
snakefoot merged 1 commit intoOct 24, 2023
NLog:devNLog/NLog:devfrom
snakefoot:fix-UpdateCreationTimesnakefoot/NLog:fix-UpdateCreationTimeCopy head branch name to clipboard
Merged
FileTarget - Removed explicit File.Create to not trigger file-scanners#5381snakefoot merged 1 commit intoNLog:devNLog/NLog:devfrom snakefoot:fix-UpdateCreationTimesnakefoot/NLog:fix-UpdateCreationTimeCopy head branch name to clipboard
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:fix-UpdateCreationTimesnakefoot/NLog:fix-UpdateCreationTimeCopy head branch name to clipboard
Conversation
snakefoot
force-pushed
the
fix-UpdateCreationTime
branch
from
October 24, 2023 19:20
ea9d06a to
0248b51
Compare
snakefoot
force-pushed
the
fix-UpdateCreationTime
branch
2 times, most recently
from
October 24, 2023 19:33
802265f to
cd2b44a
Compare
snakefoot
force-pushed
the
fix-UpdateCreationTime
branch
8 times, most recently
from
October 24, 2023 20:18
7988a46 to
fcf3750
Compare
snakefoot
enabled auto-merge (squash)
October 24, 2023 20:20
snakefoot
force-pushed
the
fix-UpdateCreationTime
branch
2 times, most recently
from
October 24, 2023 20:27
cb03ad4 to
af163fe
Compare
snakefoot
force-pushed
the
fix-UpdateCreationTime
branch
from
October 24, 2023 20:55
af163fe to
78b6605
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Oct 24, 2023
This was referenced Dec 8, 2025
This was referenced Jan 7, 2026
This was referenced Jan 27, 2026
This was referenced Apr 22, 2026
This was referenced May 29, 2026
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileTarget should not momentarily release FileStream-handle on file-creation, as it might be locked-out by file-scanner that take exclusive lock (Thus preventing NLog from actually logging just after file-creation). See also #5379
But still trying to keep work-around for Windows FileSystem Tunneling (avoid newly-created-file re-using timestamp from from previous-file after file-archive/file-move). See also: #1100 and #1125