Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

NetworkTarget - Skip connection when above max message size - #5370

#5370
Merged
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:network-target-msg-maxsizesnakefoot/NLog:network-target-msg-maxsizeCopy head branch name to clipboard
Oct 14, 2023
Merged

NetworkTarget - Skip connection when above max message size#5370
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:network-target-msg-maxsizesnakefoot/NLog:network-target-msg-maxsizeCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Oct 14, 2023

Copy link
Copy Markdown
Contributor

When going to discard payload because larger than MaxMessageSize, then no need to establish connection.

There is a minor breaking as it will no longer make connection-handshake when payload above max-message-size, or when payload is zero bytes.

@snakefoot snakefoot added enhancement Improvement on existing feature network/NLogViewer-target labels Oct 14, 2023
@snakefoot snakefoot added this to the 5.2.5 milestone Oct 14, 2023
@snakefoot
snakefoot force-pushed the network-target-msg-maxsize branch from c01d69a to 949ddf0 Compare October 14, 2023 15:44
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@snakefoot
snakefoot enabled auto-merge (squash) October 14, 2023 15:59
@snakefoot
snakefoot merged commit abe2338 into NLog:dev Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.