Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

AutoFlushTargetWrapper - Explicit flush should also await when FlushOnConditionOnly - #5308

#5308
Merged
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:autoflush-explicit-waitssnakefoot/NLog:autoflush-explicit-waitsCopy head branch name to clipboard
Aug 5, 2023
Merged

AutoFlushTargetWrapper - Explicit flush should also await when FlushOnConditionOnly#5308
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:autoflush-explicit-waitssnakefoot/NLog:autoflush-explicit-waitsCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

Trying to resolve #5305

NLog.LogManager.Flush(); // will now await already pending async-flush-operations when FlushOnConditionOnly = true

@snakefoot snakefoot added the enhancement Improvement on existing feature label Aug 5, 2023
@snakefoot snakefoot added this to the 5.2.3 milestone Aug 5, 2023
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@snakefoot
snakefoot merged commit 6eab802 into NLog:dev Aug 5, 2023
@snakefoot snakefoot changed the title AutoFlushTargetWrapper - Explicit flush should await when FlushOnConditionOnly AutoFlushTargetWrapper - Explicit flush should also await when FlushOnConditionOnly Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement on existing feature size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network target not working with AutoFlushWrapper and BufferingWrapper

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.