Remove irrelevant StructuredMessageTemplateAttribute - #5266
#5266Merged
snakefoot merged 1 commit intoJun 26, 2023
NLog:devNLog/NLog:devfrom
saltukkos:annotations-resharpersaltukkos/NLog:annotations-resharperCopy head branch name to clipboard
Merged
Remove irrelevant StructuredMessageTemplateAttribute#5266snakefoot merged 1 commit intoNLog:devNLog/NLog:devfrom saltukkos:annotations-resharpersaltukkos/NLog:annotations-resharperCopy head branch name to clipboard
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
saltukkos:annotations-resharpersaltukkos/NLog:annotations-resharperCopy head branch name to clipboard
Conversation
|
Thanks for opening this pull request! |
|
Kudos, SonarCloud Quality Gate passed!
|
snakefoot
self-requested a review
June 26, 2023 17:26
snakefoot
approved these changes
Jun 26, 2023
snakefoot
left a comment
Contributor
There was a problem hiding this comment.
Thank you for reporting this, and resolving it with this pull-request.
|
Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks! |
Contributor
|
NLog v5.2.1 has now been released - https://www.nuget.org/packages/NLog Thank you again for taking the time to report and fix this issues. |
This was referenced Aug 26, 2025
This was referenced Dec 8, 2025
This was referenced Jan 11, 2026
This was referenced Jan 27, 2026
This was referenced Apr 22, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that some overloads in
ILoggerhave the[StructuredMessageTemplate]but they don't actually treat the input as a structured message, instead treating it like a regular string. This leads to false-positives in R# and irrelevant syntax highlighting. I believe these attributes shouldn't be here, as they are only applied to theDebuglevel (search link) (andFatalfor obsolete version of the method). Note that these methods also don't have[MessageTemplateFormatMethod].