ConfigurationItemFactory - Skip assembly-loading should also check prefix-option - #5257
#5257Merged
snakefoot merged 1 commit intoJun 14, 2023
NLog:devNLog/NLog:devfrom
snakefoot:assembly-prefix-not-skipsnakefoot/NLog:assembly-prefix-not-skipCopy head branch name to clipboard
Merged
ConfigurationItemFactory - Skip assembly-loading should also check prefix-option#5257snakefoot merged 1 commit intoNLog:devNLog/NLog:devfrom snakefoot:assembly-prefix-not-skipsnakefoot/NLog:assembly-prefix-not-skipCopy head branch name to clipboard
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:assembly-prefix-not-skipsnakefoot/NLog:assembly-prefix-not-skipCopy head branch name to clipboard
Conversation
snakefoot
force-pushed
the
assembly-prefix-not-skip
branch
2 times, most recently
from
June 14, 2023 20:21
d7cee47 to
da5fa2a
Compare
snakefoot
enabled auto-merge (squash)
June 14, 2023 20:32
snakefoot
force-pushed
the
assembly-prefix-not-skip
branch
3 times, most recently
from
June 14, 2023 20:48
a8447c5 to
0fbdd33
Compare
snakefoot
force-pushed
the
assembly-prefix-not-skip
branch
from
June 14, 2023 20:48
0fbdd33 to
60ec8e9
Compare
|
SonarCloud Quality Gate failed. |
This was referenced Aug 26, 2025
This was referenced Dec 8, 2025
This was referenced Jan 11, 2026
This was referenced Jan 27, 2026
This was referenced Apr 22, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5256 - Bug introduced with NLog v5.2 by #5191
NLog v5.2 introduced an optimization to skip assembly-reflection, when already loaded the recommended way, but it failed to recognize the use of custom assembly-prefix