LogFactory - Obsoleted GetLogger should not throw exceptions when invalid logger-type - #5255
#5255Merged
snakefoot merged 1 commit intoJun 13, 2023
NLog:devNLog/NLog:devfrom
snakefoot:logfactory_custom_loggersnakefoot/NLog:logfactory_custom_loggerCopy head branch name to clipboard
Merged
LogFactory - Obsoleted GetLogger should not throw exceptions when invalid logger-type#5255snakefoot merged 1 commit intoNLog:devNLog/NLog:devfrom snakefoot:logfactory_custom_loggersnakefoot/NLog:logfactory_custom_loggerCopy head branch name to clipboard
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:logfactory_custom_loggersnakefoot/NLog:logfactory_custom_loggerCopy head branch name to clipboard
Conversation
…ng invalid logger-type
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Aug 26, 2025
This was referenced Dec 8, 2025
This was referenced Jan 11, 2026
This was referenced Jan 27, 2026
This was referenced Apr 22, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only throw first-chance-exception, when
ThrowExceptions = trueelse just fail silently like before (fallback to default Logger).Reverting behavior change introduced with #5191. See also #5252
Not sure I like the behavior of silently failing, but luckily the
GetLogger-method is obsolete :)