Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

NLogTraceListener - Align Filter-behavior for all Write-methods - #5242

#5242
Merged
snakefoot merged 2 commits into
NLog:devNLog/NLog:devfrom
snakefoot:devsnakefoot/NLog:devCopy head branch name to clipboard
Mar 30, 2024
Merged

NLogTraceListener - Align Filter-behavior for all Write-methods#5242
snakefoot merged 2 commits into
NLog:devNLog/NLog:devfrom
snakefoot:devsnakefoot/NLog:devCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Jun 5, 2023

Copy link
Copy Markdown
Contributor
  • Waiting for NLog v5.3

Align Filter-behavior for all Write-methods to match default TraceListener-implementation (Handled as TraceEventType.Verbose):

  • Write(string message)
  • Write(object o)
  • WriteLine(string message)
  • WriteLine(object o)

Skip allocation of the LogEventInfo.Properties-dictionary, when TraceEventType.Verbose.

Attempt to capture Exception when passed to Write(object o) or WriteLine(object o).

Attempt to improve improve ${callsite}-output, by hidding typeof(System.Diagnostics.Trace)

@snakefoot snakefoot changed the title NLogTraceListener - Updated XML docs with link to Wiki-docs NLogTraceListener - Removed TraceEventType.Resume from WriteLine Jun 5, 2023
@snakefoot
snakefoot force-pushed the dev branch 2 times, most recently from a491d3f to bb0060f Compare June 5, 2023 09:56
@pull-request-size pull-request-size Bot added size/L and removed size/S labels Jun 5, 2023
@snakefoot
snakefoot force-pushed the dev branch 5 times, most recently from bbb706a to 1ec8959 Compare June 5, 2023 17:10
@snakefoot snakefoot changed the title NLogTraceListener - Removed TraceEventType.Resume from WriteLine NLogTraceListener - Align Filter-behavior for all Write-methods: Jun 5, 2023
@snakefoot snakefoot changed the title NLogTraceListener - Align Filter-behavior for all Write-methods: NLogTraceListener - Align Filter-behavior for all Write-methods Jun 5, 2023
@sonarqubecloud

sonarqubecloud Bot commented Jun 5, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot added enhancement Improvement on existing feature and removed documentation labels Jun 5, 2023
@snakefoot snakefoot added the breaking behavior change Same API, different result label Nov 18, 2023
@sonarqubecloud

sonarqubecloud Bot commented Dec 7, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud

Copy link
Copy Markdown

@snakefoot
snakefoot merged commit ea417ce into NLog:dev Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking behavior change Same API, different result enhancement Improvement on existing feature size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.