FileTarget - Recover from file-deleted when same archive-folder - #5207
#5207Merged
snakefoot merged 1 commit intoApr 28, 2023
NLog:devNLog/NLog:devfrom
snakefoot:FileTarget_ArchiveSameFoldersnakefoot/NLog:FileTarget_ArchiveSameFolderCopy head branch name to clipboard
Merged
FileTarget - Recover from file-deleted when same archive-folder#5207snakefoot merged 1 commit intoNLog:devNLog/NLog:devfrom snakefoot:FileTarget_ArchiveSameFoldersnakefoot/NLog:FileTarget_ArchiveSameFolderCopy head branch name to clipboard
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:FileTarget_ArchiveSameFoldersnakefoot/NLog:FileTarget_ArchiveSameFolderCopy head branch name to clipboard
Conversation
snakefoot
enabled auto-merge (squash)
April 28, 2023 19:39
snakefoot
force-pushed
the
FileTarget_ArchiveSameFolder
branch
from
April 28, 2023 19:53
d1fe49f to
88bb8d3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Dec 28, 2023
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Dec 28, 2023
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Dec 28, 2023
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Dec 28, 2023
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Dec 28, 2023
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Dec 28, 2023
snakefoot
added a commit
to snakefoot/NLog
that referenced
this pull request
Dec 28, 2023
This was referenced Dec 8, 2025
This was referenced Jan 27, 2026
This was referenced Apr 22, 2026
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5203
Skip optimization to ignore certain file-operations when happening in the archive-folder-destination-folder, when using
concurrentWrites="true"(because it conflicts with same folder-archive-situations).Since
concurrentWrites="false"is the new default with NLog v5, then I'm not that worried about removing these specials optimizations forconcurrentWrites="true", when conflicting with same-folder-archive-logic (that was approved with NLog v4.5)