Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

LogEventInfo with custom MessageFormatter now generates FormattedMessage upfront - #5121

#5121
Merged
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:devsnakefoot/NLog:devCopy head branch name to clipboard
Dec 4, 2022
Merged

LogEventInfo with custom MessageFormatter now generates FormattedMessage upfront#5121
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:devsnakefoot/NLog:devCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Dec 4, 2022

Copy link
Copy Markdown
Contributor

Cannot predict whether custom MessageFormatter is thread-agnostic.

Also it improves performance when used together with NLog.Extensions.Logging (Skipping NeedToPreformatMessage)

@sonarqubecloud

sonarqubecloud Bot commented Dec 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot
snakefoot merged commit 373bbf4 into NLog:dev Dec 4, 2022
@snakefoot snakefoot added this to the 5.1.1 milestone Dec 12, 2022
@snakefoot snakefoot changed the title LogEventInfo with custom MessageFormatter should assign FormattedMessage LogEventInfo with custom MessageFormatter now generates FormattedMessage upfront Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.