Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

AutoFlushTargetWrapper - Fix race-condition that makes unit-tests unstable - #5076

#5076
Merged
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:asyncflush-bugfixsnakefoot/NLog:asyncflush-bugfixCopy head branch name to clipboard
Sep 29, 2022
Merged

AutoFlushTargetWrapper - Fix race-condition that makes unit-tests unstable#5076
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:asyncflush-bugfixsnakefoot/NLog:asyncflush-bugfixCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Flush-registration (that are also seen as pending operations) should correctly notify/release other flush-registrations running concurrently.

Flush-registrations are only released when all original pending operations have completed. Bug introduced with #1868

@snakefoot snakefoot added bug Bug report / Bug fix unit-tests labels Sep 27, 2022
@snakefoot
snakefoot force-pushed the asyncflush-bugfix branch 3 times, most recently from cb8a853 to 63477e7 Compare September 27, 2022 21:58
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug report / Bug fix size/L unit-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.