Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Max StackTraceUsage should be computed using bitwise OR - #4965

#4965
Merged
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
martinzding:patch-1Copy head branch name to clipboard
Jun 10, 2022
Merged

Max StackTraceUsage should be computed using bitwise OR#4965
snakefoot merged 1 commit into
NLog:devNLog/NLog:devfrom
martinzding:patch-1Copy head branch name to clipboard

Conversation

@martinzding

Copy link
Copy Markdown
Contributor

The StackTraceUsage of a layout is currently using Max to compute the maximum value. This is buggy when individual StackTraceUsage values have overlapping bits.

@welcome

welcome Bot commented Jun 10, 2022

Copy link
Copy Markdown

Thanks for opening this pull request!
We will try to review this soon! Please note that pull requests with unit tests are earlier accepted 👼

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot added this to the 5.0.1 milestone Jun 10, 2022
@snakefoot snakefoot added the bug Bug report / Bug fix label Jun 10, 2022
@snakefoot
snakefoot merged commit 5c1581d into NLog:dev Jun 10, 2022
@welcome

welcome Bot commented Jun 10, 2022

Copy link
Copy Markdown

Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks!
thanks!

@snakefoot

snakefoot commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

@martinzding Thank you for spotting this. Created #4966 with actual unit-test

@snakefoot

Copy link
Copy Markdown
Contributor

NLog 5.0.1 is now available: https://www.nuget.org/packages/NLog/5.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug report / Bug fix size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.