Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

JsonSerializer - Fixed bug when handling custom IConvertible returning TypeCode.Empty - #4401

#4401
Merged
304NotModified merged 2 commits into
NLog:masterNLog/NLog:masterfrom
snakefoot:jsonlayout-emptyobjectsnakefoot/NLog:jsonlayout-emptyobjectCopy head branch name to clipboard
May 13, 2021
Merged

JsonSerializer - Fixed bug when handling custom IConvertible returning TypeCode.Empty#4401
304NotModified merged 2 commits into
NLog:masterNLog/NLog:masterfrom
snakefoot:jsonlayout-emptyobjectsnakefoot/NLog:jsonlayout-emptyobjectCopy head branch name to clipboard

Conversation

@snakefoot

Copy link
Copy Markdown
Contributor

Alternative of #4399 to fix invalid JSON format when JProperty is null

@snakefoot snakefoot added bug Bug report / Bug fix json / json-layout labels Apr 16, 2021
@snakefoot snakefoot added this to the 4.7.10 milestone Apr 16, 2021
@snakefoot
snakefoot force-pushed the jsonlayout-emptyobject branch 5 times, most recently from f8df05d to 4c2ad17 Compare April 18, 2021 18:05
@snakefoot snakefoot closed this Apr 23, 2021
@snakefoot snakefoot reopened this Apr 23, 2021
@snakefoot
snakefoot force-pushed the jsonlayout-emptyobject branch from 4c2ad17 to a161888 Compare April 23, 2021 17:03
@snakefoot
snakefoot force-pushed the jsonlayout-emptyobject branch from a161888 to 5914f88 Compare April 23, 2021 18:13
@vicentegnz

Copy link
Copy Markdown

Hello @snakefoot :)

When will version 4.7.10 be released? will it come with this change, or is it postponed for later?

Thank you very much.

@snakefoot

Copy link
Copy Markdown
Contributor Author

@vicentegnz No idea. It depends on when @304NotModified finds the optimal time-window.

Comment thread src/NLog/Internal/StringHelpers.cs Outdated
@snakefoot
snakefoot force-pushed the jsonlayout-emptyobject branch from a706afb to 724fc42 Compare May 12, 2021 20:42
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@304NotModified
304NotModified merged commit 71d1e9a into NLog:master May 13, 2021
@304NotModified

Copy link
Copy Markdown
Member

When will version 4.7.10 be released? will it come with this change, or is it postponed for later?

Will release it tomorrow :)

@snakefoot

Copy link
Copy Markdown
Contributor Author

NLog v4.7.10 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.