JsonSerializer - Fixed bug when handling custom IConvertible returning TypeCode.Empty - #4401
#4401Merged
304NotModified merged 2 commits intoMay 13, 2021
NLog:masterNLog/NLog:masterfrom
snakefoot:jsonlayout-emptyobjectsnakefoot/NLog:jsonlayout-emptyobjectCopy head branch name to clipboard
Merged
JsonSerializer - Fixed bug when handling custom IConvertible returning TypeCode.Empty#4401304NotModified merged 2 commits intoNLog:masterNLog/NLog:masterfrom snakefoot:jsonlayout-emptyobjectsnakefoot/NLog:jsonlayout-emptyobjectCopy head branch name to clipboard
304NotModified merged 2 commits into
NLog:masterNLog/NLog:masterfrom
snakefoot:jsonlayout-emptyobjectsnakefoot/NLog:jsonlayout-emptyobjectCopy head branch name to clipboard
Conversation
snakefoot
force-pushed
the
jsonlayout-emptyobject
branch
5 times, most recently
from
April 18, 2021 18:05
f8df05d to
4c2ad17
Compare
snakefoot
force-pushed
the
jsonlayout-emptyobject
branch
from
April 23, 2021 17:03
4c2ad17 to
a161888
Compare
snakefoot
force-pushed
the
jsonlayout-emptyobject
branch
from
April 23, 2021 18:13
a161888 to
5914f88
Compare
|
Hello @snakefoot :) When will version 4.7.10 be released? will it come with this change, or is it postponed for later? Thank you very much. |
Contributor
Author
|
@vicentegnz No idea. It depends on when @304NotModified finds the optimal time-window. |
…g TypeCode.Empty (undo refactoring)
snakefoot
force-pushed
the
jsonlayout-emptyobject
branch
from
May 12, 2021 20:42
a706afb to
724fc42
Compare
|
Kudos, SonarCloud Quality Gate passed! |
304NotModified
approved these changes
May 13, 2021
Member
Will release it tomorrow :) |
Contributor
Author
|
NLog v4.7.10 has been released. |
This was referenced Sep 2, 2025
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative of #4399 to fix invalid JSON format when JProperty is null