Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix TrimDirectorySeparators to handle root-path on Windows and Linux - #4316

#4316
Merged
snakefoot merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:load_config_from_root_pathsnakefoot/NLog:load_config_from_root_pathCopy head branch name to clipboard
Feb 24, 2021
Merged

Fix TrimDirectorySeparators to handle root-path on Windows and Linux#4316
snakefoot merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:load_config_from_root_pathsnakefoot/NLog:load_config_from_root_pathCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

Fix loading Nlog.config when application is running at root-path (Ex. D:\). Resolves #4314

Bug introduced with #2846 in NLog 4.5.9

@snakefoot snakefoot added the bug Bug report / Bug fix label Feb 24, 2021
@snakefoot snakefoot added this to the 4.7.8 milestone Feb 24, 2021
@snakefoot snakefoot changed the title Fix TrimDirectorySeparators to handle root-path on Windows and Linux … Fix TrimDirectorySeparators to handle root-path on Windows and Linux Feb 24, 2021
@snakefoot
snakefoot force-pushed the load_config_from_root_path branch from 1a1a8b9 to 7d0e9ec Compare February 24, 2021 21:02
@304NotModified

304NotModified commented Feb 24, 2021

Copy link
Copy Markdown
Member

@snakefoot the stability of azure devops should be improved now. I've setup a restart of failed tests, and that worked, but not really as it failed on the minimum amount of tests...(meh)

LOL nice bug in Azure devops:

Total tests: 3045. Passed: 3035. Failed: 1. Skipped: 9.
##[error]Test Run Failed.
....
Failed tests: 1; Total tests: 3023;
Total failed tests as returned by TCM: 1.
Found 1 filtered test case sources.
**************** Rerunning failed tests for Test run 3674 *********************
Max attempts: 5; Current attempt: 1; Failed test cases threshold: 30; Failed test cases max limit: 0
....
Starting test execution, please wait...
....
Total tests: 1. Passed: 1. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 34.0482 Seconds
Vstest.console.exe exited with code 0.
**************** Completed test execution *********************
...
##[error]The specified minimum number of tests 100 were not executed in the test run.

full result

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.