AsyncTaskTarget - Include TaskScheduler in ContinueWith - #4176
#4176Merged
304NotModified merged 1 commit intoNov 19, 2020
NLog:masterNLog/NLog:masterfrom
snakefoot:AsyncTaskTargetBlockFlushsnakefoot/NLog:AsyncTaskTargetBlockFlushCopy head branch name to clipboard
Merged
AsyncTaskTarget - Include TaskScheduler in ContinueWith#4176304NotModified merged 1 commit intoNLog:masterNLog/NLog:masterfrom snakefoot:AsyncTaskTargetBlockFlushsnakefoot/NLog:AsyncTaskTargetBlockFlushCopy head branch name to clipboard
304NotModified merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:AsyncTaskTargetBlockFlushsnakefoot/NLog:AsyncTaskTargetBlockFlushCopy head branch name to clipboard
Conversation
…letionSource with RunContinuationsAsynchronously
|
Kudos, SonarCloud Quality Gate passed!
|
304NotModified
approved these changes
Nov 18, 2020
Member
|
Looks good! |
This was referenced Sep 2, 2025
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And create TaskCompletionSource with RunContinuationsAsynchronously. Recommended by async-tutorial:
Always create TaskCompletionSource with TaskCreationOptions.RunContinuationsAsynchronously
Guess when NLog 5.0 removes .Net4.0 then one should attempt to replace ContinueWith with async/await.