Removed EmptyDefaultDictionary from MappedDiagnosticsContext - #4115
#4115Merged
304NotModified merged 1 commit intoSep 19, 2020
NLog:masterNLog/NLog:masterfrom
snakefoot:MappedDiagnosticsContextEmptysnakefoot/NLog:MappedDiagnosticsContextEmptyCopy head branch name to clipboard
Merged
Removed EmptyDefaultDictionary from MappedDiagnosticsContext#4115304NotModified merged 1 commit intoNLog:masterNLog/NLog:masterfrom snakefoot:MappedDiagnosticsContextEmptysnakefoot/NLog:MappedDiagnosticsContextEmptyCopy head branch name to clipboard
304NotModified merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:MappedDiagnosticsContextEmptysnakefoot/NLog:MappedDiagnosticsContextEmptyCopy head branch name to clipboard
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
hi! Thanks, but why do we need this? |
Contributor
Author
Faster performance by not doing lookup in empty-dictionary, and one less static-variable. |
Member
|
Thanks! Merged! |
This was referenced Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.