Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fluent LogBuilder should suppress exception on invalid callerFilePath - #4069

#4069
Merged
304NotModified merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:LogBuilderFluentWithoutThrowingsnakefoot/NLog:LogBuilderFluentWithoutThrowingCopy head branch name to clipboard
Aug 4, 2020
Merged

Fluent LogBuilder should suppress exception on invalid callerFilePath#4069
304NotModified merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:LogBuilderFluentWithoutThrowingsnakefoot/NLog:LogBuilderFluentWithoutThrowingCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

Resolves #4067

Trying to make pretty logger-name based on callerFilePath should not lead to exception if path-value is invalid on the platform.

@snakefoot snakefoot added the bug Bug report / Bug fix label Aug 3, 2020
@snakefoot snakefoot added this to the 4.7.4 milestone Aug 3, 2020
Comment thread src/NLog/Fluent/Log.cs
@snakefoot
snakefoot force-pushed the LogBuilderFluentWithoutThrowing branch from 5dce06b to 83884b8 Compare August 4, 2020 18:25
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2020

Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@304NotModified
304NotModified merged commit ac953a9 into NLog:master Aug 4, 2020
@304NotModified

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug report / Bug fix size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.