Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ObjectReflectionCache - Skip reflection for Stream objects - #4043

#4043
Merged
304NotModified merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:ObjectReflectionStreamToStringsnakefoot/NLog:ObjectReflectionStreamToStringCopy head branch name to clipboard
Jul 10, 2020
Merged

ObjectReflectionCache - Skip reflection for Stream objects#4043
304NotModified merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:ObjectReflectionStreamToStringsnakefoot/NLog:ObjectReflectionStreamToStringCopy head branch name to clipboard

Conversation

@snakefoot

@snakefoot snakefoot commented Jul 9, 2020

Copy link
Copy Markdown
Contributor

Hard to serialize something useful from a Stream-object. Instead their properties often throw exceptions.

@snakefoot snakefoot added the enhancement Improvement on existing feature label Jul 9, 2020
@snakefoot snakefoot added this to the 4.7.3 milestone Jul 9, 2020
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@304NotModified
304NotModified merged commit 88d6f37 into NLog:master Jul 10, 2020
@304NotModified

Copy link
Copy Markdown
Member

Thanks! Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement on existing feature size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.