LogFactory Shutdown is public so it can be used from NLogLoggerProvider - #3999
#3999Merged
304NotModified merged 1 commit intoJun 2, 2020
NLog:masterNLog/NLog:masterfrom
snakefoot:LogFactoryShutdownPublicsnakefoot/NLog:LogFactoryShutdownPublicCopy head branch name to clipboard
Merged
LogFactory Shutdown is public so it can be used from NLogLoggerProvider#3999304NotModified merged 1 commit intoNLog:masterNLog/NLog:masterfrom snakefoot:LogFactoryShutdownPublicsnakefoot/NLog:LogFactoryShutdownPublicCopy head branch name to clipboard
304NotModified merged 1 commit into
NLog:masterNLog/NLog:masterfrom
snakefoot:LogFactoryShutdownPublicsnakefoot/NLog:LogFactoryShutdownPublicCopy head branch name to clipboard
Conversation
snakefoot
force-pushed
the
LogFactoryShutdownPublic
branch
from
June 1, 2020 22:05
6a8057b to
c1c6579
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
Thanks! |
1 task
This was referenced Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows this TODO to be fixed:
https://github.com/NLog/NLog.Extensions.Logging/blob/3c64a51328ace81efa2a6a0696926a29a53a7261/src/NLog.Extensions.Logging/Logging/NLogLoggerProvider.cs#L87
And also make NLog work better with isolated LogFactory-instances.