Log4JXml - Removed redundant logging of exception, default IncludeNLogData to false - #2672
#2672Merged
304NotModified merged 1 commit intoMay 5, 2019
NLog:devNLog/NLog:devfrom
snakefoot:Log4JXMLEventSingleExceptionsnakefoot/NLog:Log4JXMLEventSingleExceptionCopy head branch name to clipboard
Merged
Log4JXml - Removed redundant logging of exception, default IncludeNLogData to false#2672304NotModified merged 1 commit intoNLog:devNLog/NLog:devfrom snakefoot:Log4JXMLEventSingleExceptionsnakefoot/NLog:Log4JXMLEventSingleExceptionCopy head branch name to clipboard
304NotModified merged 1 commit into
NLog:devNLog/NLog:devfrom
snakefoot:Log4JXMLEventSingleExceptionsnakefoot/NLog:Log4JXMLEventSingleExceptionCopy head branch name to clipboard
Conversation
snakefoot
force-pushed
the
Log4JXMLEventSingleException
branch
2 times, most recently
from
April 24, 2018 20:25
5ccb3de to
a18fb48
Compare
Codecov Report
@@ Coverage Diff @@
## master #2672 +/- ##
=======================================
- Coverage 81% 81% -<1%
=======================================
Files 326 326
Lines 24320 24180 -140
Branches 3085 3075 -10
=======================================
- Hits 19667 19546 -121
+ Misses 3821 3800 -21
- Partials 832 834 +2 |
304NotModified
approved these changes
Apr 29, 2018
snakefoot
force-pushed
the
Log4JXMLEventSingleException
branch
from
June 29, 2018 20:07
c5ce689 to
979a5c7
Compare
Contributor
Author
|
Added |
Member
|
Please rebase this, and then I will merge it - thanks! |
snakefoot
force-pushed
the
Log4JXMLEventSingleException
branch
from
May 5, 2019 19:28
979a5c7 to
446bfde
Compare
Contributor
Author
Done |
snakefoot
force-pushed
the
Log4JXMLEventSingleException
branch
4 times, most recently
from
May 5, 2019 19:52
838d6c1 to
51dbdeb
Compare
…e handling when IncludeNLogData = false.
snakefoot
force-pushed
the
Log4JXMLEventSingleException
branch
from
May 5, 2019 19:54
51dbdeb to
50817db
Compare
Member
|
Thanks! |
Codecov Report
@@ Coverage Diff @@
## dev #2672 +/- ##
======================================
- Coverage 81% 81% -<1%
======================================
Files 344 344
Lines 27537 27547 +10
Branches 3697 3700 +3
======================================
- Hits 22245 22234 -11
- Misses 4225 4245 +20
- Partials 1067 1068 +1 |
Contributor
Author
|
Updated wiki: https://github.com/NLog/NLog/wiki/Log4JXMLEvent-Layout-Renderer (With new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip NLog-namespace handling when IncludeNLogData = false.
For NLog 5.0
This change is