fix(security): 2 improvements across 1 files#1401
Open
tomaioo wants to merge 1 commit into
ModelTC:mainModelTC/LightLLM:mainfrom
tomaioo:fix/security/command-injection-via-os-system-in-formatomaioo/LightLLM:fix/security/command-injection-via-os-system-in-formaCopy head branch name to clipboard
Open
fix(security): 2 improvements across 1 files#1401tomaioo wants to merge 1 commit intoModelTC:mainModelTC/LightLLM:mainfrom tomaioo:fix/security/command-injection-via-os-system-in-formatomaioo/LightLLM:fix/security/command-injection-via-os-system-in-formaCopy head branch name to clipboard
tomaioo wants to merge 1 commit into
ModelTC:mainModelTC/LightLLM:mainfrom
tomaioo:fix/security/command-injection-via-os-system-in-formatomaioo/LightLLM:fix/security/command-injection-via-os-system-in-formaCopy head branch name to clipboard
Conversation
- Security: Command Injection via os.system in Formatting Script - Quality: Command injection vulnerability in formatting script Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 1 files
Problem
Severity:
Medium| File:format.py:L4The
format.pyscript usesos.system(f"autopep8 ... {filename}")wherefilenameis derived fromglob.glob. Whileglob.globis generally safe, usingos.systemwith f-strings is a dangerous anti-pattern. If the repository is ever cloned or placed in a directory with maliciously named Python files (e.g., a file namedfoo.py; rm -rf /), it could lead to arbitrary command execution.Solution
Replace
os.systemwithsubprocess.runusing a list of arguments to avoid shell interpretation. For example:subprocess.run(['autopep8', '--max-line-length', '140', '--in-place', '--aggressive', '--aggressive', filename]).Changes
format.py(modified)