Revert change that introduced thread-safety bug - #1579
#1579Merged
AArnott merged 2 commits intoMar 16, 2023
MessagePack-CSharp:masterMessagePack-CSharp/MessagePack-CSharp:masterfrom
AArnott:dev/andarno/compilerWarningFixAArnott/MessagePack-CSharp:dev/andarno/compilerWarningFixCopy head branch name to clipboard
Merged
Revert change that introduced thread-safety bug#1579AArnott merged 2 commits intoMessagePack-CSharp:masterMessagePack-CSharp/MessagePack-CSharp:masterfrom AArnott:dev/andarno/compilerWarningFixAArnott/MessagePack-CSharp:dev/andarno/compilerWarningFixCopy head branch name to clipboard
AArnott merged 2 commits into
MessagePack-CSharp:masterMessagePack-CSharp/MessagePack-CSharp:masterfrom
AArnott:dev/andarno/compilerWarningFixAArnott/MessagePack-CSharp:dev/andarno/compilerWarningFixCopy head branch name to clipboard
Conversation
This fixes a regression introduced in a398f71. I misunderstood that the `TryAddInternal` method *always* sets the out value even when returning false.
This was referenced Oct 26, 2025
This was referenced Dec 2, 2025
This was referenced Jan 22, 2026
This was referenced Jun 11, 2026
This was referenced Jun 11, 2026
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in a398f71.
I misunderstood that the
TryAddInternalmethod always sets the out value even when returning false.