Fixed issue with Union formatter generator - #1553
#1553Merged
AArnott merged 2 commits intoMar 11, 2023
MessagePack-CSharp:developMessagePack-CSharp/MessagePack-CSharp:developfrom
Shapes-R-D:fixUnionTemplateShapes-R-D/MessagePack-CSharp:fixUnionTemplateCopy head branch name to clipboard
Merged
Fixed issue with Union formatter generator#1553AArnott merged 2 commits intoMessagePack-CSharp:developMessagePack-CSharp/MessagePack-CSharp:developfrom Shapes-R-D:fixUnionTemplateShapes-R-D/MessagePack-CSharp:fixUnionTemplateCopy head branch name to clipboard
AArnott merged 2 commits into
MessagePack-CSharp:developMessagePack-CSharp/MessagePack-CSharp:developfrom
Shapes-R-D:fixUnionTemplateShapes-R-D/MessagePack-CSharp:fixUnionTemplateCopy head branch name to clipboard
Conversation
Scormave
force-pushed
the
fixUnionTemplate
branch
from
January 26, 2023 08:26
f28bc0b to
809d1ad
Compare
Collaborator
|
/azp run |
This was referenced Oct 26, 2025
This was referenced Dec 2, 2025
This was referenced Jan 22, 2026
This was referenced Jun 11, 2026
This was referenced Jun 11, 2026
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating a formatter for a Union, there is a missing reference to MessagePack namespace. Another option is to use direct call of GetFormatterWithVerify method as it's done everywhere.