Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MessagePack.Generator.csproj target to net7.0 - #1542

#1542
Closed
neuecc wants to merge 2 commits into
masterMessagePack-CSharp/MessagePack-CSharp:masterfrom
mpc-update-net7MessagePack-CSharp/MessagePack-CSharp:mpc-update-net7Copy head branch name to clipboard
Closed

MessagePack.Generator.csproj target to net7.0#1542
neuecc wants to merge 2 commits into
masterMessagePack-CSharp/MessagePack-CSharp:masterfrom
mpc-update-net7MessagePack-CSharp/MessagePack-CSharp:mpc-update-net7Copy head branch name to clipboard

Conversation

@neuecc

@neuecc neuecc commented Dec 5, 2022

Copy link
Copy Markdown
Member

If only install dotnet sdk 7,0(does not install sdk 6.0)

image

mpc fail to get metadata so can't execute it.

image

using net7.0 success.

image

@AArnott require to change global.json and CI?

@neuecc
neuecc requested a review from AArnott December 5, 2022 02:36

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised this change is necessary since we already have <RollForward>Major</RollForward> in this project file, but I have no objection to this change if it fixes the problem.

@AArnott

AArnott commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

require to change global.json and CI?

If you're noticing the Azure Pipelines status failure, it isn't because of this PR. It's because I was too eager to delete my own unity agent once I switched the develop branch to use GitHub Actions. I'll try to adapt that change to the master branch as well.

@AArnott

AArnott commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

See #1543 for a fix for the PR build.

@AArnott

AArnott commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

Oh, I see now. The master branch still uses the .NET 6 SDK so you can't target .NET 7.
All our .NET 7 support is in the develop branch. In fact in the develop branch this project already includes a .NET 7 target:
https://github.com/neuecc/MessagePack-CSharp/blob/develop/src/MessagePack.Generator/MessagePack.Generator.csproj#LL6C55-L6C55

Will that suffice? I did ship a beta from the develop branch a few days ago (https://www.nuget.org/packages/MessagePack/2.5.64-alpha) so you can even try it out.

@github-actions

github-actions Bot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@AArnott AArnott mentioned this pull request Mar 11, 2023
@AArnott AArnott closed this Mar 11, 2023
@AArnott
AArnott deleted the mpc-update-net7 branch March 11, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.