Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add incremental build support to MessagePack.MSBuild.Tasks - #1528

#1528
Merged
AArnott merged 1 commit into
MessagePack-CSharp:masterMessagePack-CSharp/MessagePack-CSharp:masterfrom
AArnott:fix1526AArnott/MessagePack-CSharp:fix1526Copy head branch name to clipboard
Nov 19, 2022
Merged

Add incremental build support to MessagePack.MSBuild.Tasks#1528
AArnott merged 1 commit into
MessagePack-CSharp:masterMessagePack-CSharp/MessagePack-CSharp:masterfrom
AArnott:fix1526AArnott/MessagePack-CSharp:fix1526Copy head branch name to clipboard

Conversation

@AArnott

@AArnott AArnott commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

Fixes #1526

@AArnott AArnott added this to the v2.4 milestone Nov 19, 2022
@AArnott
AArnott merged commit e9cdd76 into MessagePack-CSharp:master Nov 19, 2022
@AArnott
AArnott deleted the fix1526 branch November 19, 2022 15:52
@hankovich

Copy link
Copy Markdown
Contributor

It looks like the GeneratedFileName constant in the task is no longer needed.

@AArnott

AArnott commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator Author

Ah yes, good eye @hankovich. I'll make a follow-up PR to clean that up.

@AArnott

AArnott commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator Author

see #1529

@hankovich

Copy link
Copy Markdown
Contributor

see #1529

Great stuff!
Thanks for the quick fix. When are you going release a new package version?

@AArnott

AArnott commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator Author

See #1519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GenerateMessagePackResolver MsBuild target breaks incremental build

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.