Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

.NET 6 Update - #1355

#1355
Merged
AArnott merged 36 commits into
MessagePack-CSharp:developMessagePack-CSharp/MessagePack-CSharp:developfrom
pCYSl5EDgo:UpdateRoslynv4pCYSl5EDgo/MessagePack-CSharp:UpdateRoslynv4Copy head branch name to clipboard
Dec 25, 2021
Merged

.NET 6 Update#1355
AArnott merged 36 commits into
MessagePack-CSharp:developMessagePack-CSharp/MessagePack-CSharp:developfrom
pCYSl5EDgo:UpdateRoslynv4pCYSl5EDgo/MessagePack-CSharp:UpdateRoslynv4Copy head branch name to clipboard

Conversation

@pCYSl5EDgo

Copy link
Copy Markdown
Contributor

This PR is a solution for #1353.
I do not write test codes for C# 10 because current global.json targets .net 5.0.401.
Another .net 6 update PR is necessary for the tests.

@pCYSl5EDgo
pCYSl5EDgo changed the base branch from master to develop December 6, 2021 08:07
@neuecc

neuecc commented Dec 6, 2021

Copy link
Copy Markdown
Member

I think we should add net6.0 to mpc targetframeworks.

@pCYSl5EDgo

pCYSl5EDgo commented Dec 6, 2021

Copy link
Copy Markdown
Contributor Author

Additional work on azure pipeline seems to be needed.

@pCYSl5EDgo

Copy link
Copy Markdown
Contributor Author

Why MessagePackSecurityTests.EqualityComparer_Single fails???

@pCYSl5EDgo

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 1355 in repo neuecc/MessagePack-CSharp

@pCYSl5EDgo pCYSl5EDgo changed the title Update Roslyn V4 .NET 6 Update Dec 9, 2021
@pCYSl5EDgo

pCYSl5EDgo commented Dec 9, 2021

Copy link
Copy Markdown
Contributor Author

@AArnott
Would you review after this CI passes?
I do not know why Unity env test is not conducted.

Changes

Azure Pipelines update

  • windows 2022 & VS2022

.NET 6 Support added

  • global.json change
  • MessagePack.csproj
  • MessagePack.Generator.csproj

MPC C# 10 Test added

  • global using
  • file scoped namespace

Bug fix

  • MessagePackSecurityTest.cs

Dependency update

  • Directory.Build.props

This was referenced Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.