Fix MessagePackFormatterAttribute for many built-in formatter types - #1330
#1330Merged
AArnott merged 3 commits intoNov 5, 2021
Merged
Fix MessagePackFormatterAttribute for many built-in formatter types#1330AArnott merged 3 commits into
AArnott merged 3 commits into
Conversation
neuecc
approved these changes
Sep 30, 2021
neuecc
left a comment
Member
There was a problem hiding this comment.
Thank you, it's very good.
(To be honest, I was thinking public constructor for everything, but it looks good)
Collaborator
Author
|
/azp run |
1 similar comment
Collaborator
Author
|
/azp run |
AArnott
force-pushed
the
fix1328
branch
3 times, most recently
from
November 5, 2021 16:21
82683ff to
e456001
Compare
…r mismatches the declared member type
This was referenced Oct 26, 2025
This was referenced Dec 2, 2025
This was referenced Jun 11, 2026
This was referenced Jun 11, 2026
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the formatter singleton pattern to
MessagePackFormatterAttribute.Without this, 90 of our 172 formatters break when used with this attribute.
Fixes #1328