add ability for user to delete a DM thread#2040
Draft
blued-gear wants to merge 7 commits into
Draft
add ability for user to delete a DM thread#2040blued-gear wants to merge 7 commits into
blued-gear wants to merge 7 commits into
Conversation
Contributor
|
This PR is stale because it has been open 40 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, while implementing reports I found inefficiencies in our codebase (too many instanceof checks and code-duplications).
So this PR now also includes a refactor which introduces
SwitchingServiceRegistry. This new service can (and should from now on) be used to retrieve an implementation of a requested interface which fits a certain object to handle. Kinda like a centralized instanceof switch.fixes #1423