fix(firestore): fix get and getall method of transaction#96
Draft
HemangChothani wants to merge 1 commit into
masterMaxxleLLC/google-cloud-python:masterfrom
firestore_fix_transaction_get_methodMaxxleLLC/google-cloud-python:firestore_fix_transaction_get_methodCopy head branch name to clipboard
Draft
fix(firestore): fix get and getall method of transaction#96HemangChothani wants to merge 1 commit intomasterMaxxleLLC/google-cloud-python:masterfrom firestore_fix_transaction_get_methodMaxxleLLC/google-cloud-python:firestore_fix_transaction_get_methodCopy head branch name to clipboard
HemangChothani wants to merge 1 commit into
masterMaxxleLLC/google-cloud-python:masterfrom
firestore_fix_transaction_get_methodMaxxleLLC/google-cloud-python:firestore_fix_transaction_get_methodCopy head branch name to clipboard
Conversation
IlyaFaer
approved these changes
Jan 9, 2020
mf2199
approved these changes
Jan 9, 2020
mf2199
left a comment
Collaborator
There was a problem hiding this comment.
I'd also post a brief description of the issue root cause and why it's transaction.py and not _helpers.py that have to be modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPR 10078