BigTable: add 'client_options' support to Client#61
Closed
emar-kar wants to merge 3 commits into
masterMaxxleLLC/google-cloud-python:masterfrom
iss-8475-(BigTable)MaxxleLLC/google-cloud-python:iss-8475-(BigTable)Copy head branch name to clipboard
Closed
BigTable: add 'client_options' support to Client#61emar-kar wants to merge 3 commits intomasterMaxxleLLC/google-cloud-python:masterfrom iss-8475-(BigTable)MaxxleLLC/google-cloud-python:iss-8475-(BigTable)Copy head branch name to clipboard
emar-kar wants to merge 3 commits into
masterMaxxleLLC/google-cloud-python:masterfrom
iss-8475-(BigTable)MaxxleLLC/google-cloud-python:iss-8475-(BigTable)Copy head branch name to clipboard
Conversation
IlyaFaer
reviewed
Sep 24, 2019
| :type client_options: :class:`~google.api_core.client_options.ClientOptions` | ||
| or :class:`dict` | ||
| :param client_options: (Optional) Client options used to set user options | ||
| on the client. API Endpoint should be set through client_options. |
Collaborator
There was a problem hiding this comment.
client_options must be marked with ``
Author
There was a problem hiding this comment.
I checked all over libraries, they are not marked there.
Collaborator
There was a problem hiding this comment.
Looks like Bu Sun Kim didn't wrote such marking, but usually source code is marked like this
Well, on your will
IlyaFaer
approved these changes
Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPR: 8475