refactor(bigquery): add extract table and table cmek operations#101
Draft
HemangChothani wants to merge 3 commits into
masterMaxxleLLC/google-cloud-python:masterfrom
bigquery_update_table_cmek_extract_table_code_samplesMaxxleLLC/google-cloud-python:bigquery_update_table_cmek_extract_table_code_samplesCopy head branch name to clipboard
Draft
refactor(bigquery): add extract table and table cmek operations#101HemangChothani wants to merge 3 commits intomasterMaxxleLLC/google-cloud-python:masterfrom bigquery_update_table_cmek_extract_table_code_samplesMaxxleLLC/google-cloud-python:bigquery_update_table_cmek_extract_table_code_samplesCopy head branch name to clipboard
HemangChothani wants to merge 3 commits into
masterMaxxleLLC/google-cloud-python:masterfrom
bigquery_update_table_cmek_extract_table_code_samplesMaxxleLLC/google-cloud-python:bigquery_update_table_cmek_extract_table_code_samplesCopy head branch name to clipboard
Conversation
IlyaFaer
approved these changes
Jan 21, 2020
IlyaFaer
left a comment
Collaborator
There was a problem hiding this comment.
I'm little bit lost in all the rules for this refactoring, but LGTM
Only too many empty lines I think
|
|
||
|
|
||
| def test_create_table_cmek(capsys, random_table_id, kms_key_name): | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
@IlyaFaer just following the structure and rules as , all files has one blank line after method declaration and pep8 for two blank line between import and method declaration.
| out, _ = capsys.readouterr() | ||
| assert "Exported {} ".format(table_with_data_id) in out | ||
| assert blob.exists | ||
| assert blob.size > 0 |
Collaborator
There was a problem hiding this comment.
In fact you can write just assert blob.size as it's not going to be negative, and it'll give True for all positive numbers
Collaborator
Author
There was a problem hiding this comment.
@IlyaFaer Ok, but i i didn't change that assert , i keep as it is as it was before.
mf2199
approved these changes
Jan 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards[8989]
List of changes: