remove all useless header comments#3363
Merged
rejas merged 4 commits intoJan 24, 2024
Merged
remove all useless header comments#3363
Conversation
…f -exec perl -i -0pe 's/\/\*\s*magicmirror.*?\*\/\s*//si' {} \;`
Collaborator
|
What do you suggest how we proceed? Comment on the parts where we shouldn't delete everything? |
Collaborator
Author
|
I would delete everything except: config/config.js.sample
css/custom.css.sample
modules/default/weather/providers/envcanada.js
modules/default/weather/providers/ukmetofficedatahub.js
modules/default/weather/providers/weathergov.js
tests/configs/modules/calendar/exdate.jsIn above exceptions we should remove:
|
Collaborator
|
Sounds good 👍 I haven't noticed anything else that I would keep. |
khassel
marked this pull request as ready for review
January 18, 2024 22:47
rejas
requested changes
Jan 24, 2024
Collaborator
Author
|
test fails are unrelated, we have Wednesday so the one test will fail today ... |
rejas
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #3358
used command:
find ./ -type f -exec perl -i -0pe 's/\/\*\s*magicmirror.*?\*\/\s*//si' {} \;This is a first draft, I think we should preserve some of the comments.