Fix CDF5 and int32 in files_for_e3sm
#897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires converting many functions to methods.
Collaborator
Author
TestingI have tested this and MPAS-Dev/MPAS-Tools#603 together in: While not all steps have completed, I am not seeing any int64 and all output files except masks used for diagnostics are in cdf5 format as requested. (The diagnostics masks in netcdf4 format shouldn't cause any trouble.) |
Collaborator
Author
|
I'm going to merge this so I can rebase #881 onto these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RRSwISC6to18E3r5 mesh had mesh, initial condition and mask files that were in NetCDF4 format, not CDF5. This PR aims to fix that.
We also have seen int64 fields in masks. This should be fixed in MPAS-Dev/MPAS-Tools#603, so this PR should introduce a new MPAS-Tools version that brings in that change as well.
For the MOC mask file in
inputdata, this merge also adopts the naming convention from E3SM-Project/E3SM#7165, e.g.:Checklist
Testingin this PR) any testing that was used to verify the changes