Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bump datedstamp on several RRSwISC6to18E3r5 inputdata files#7165

Merged
jonbob merged 4 commits intoE3SM-Project:masterE3SM-Project/E3SM:masterfrom
xylar:ocn/fix-rrswisc6to18e3r5-moc-mask-filenamexylar/E3SM:ocn/fix-rrswisc6to18e3r5-moc-mask-filenameCopy head branch name to clipboard
Mar 27, 2025
Merged

Bump datedstamp on several RRSwISC6to18E3r5 inputdata files#7165
jonbob merged 4 commits intoE3SM-Project:masterE3SM-Project/E3SM:masterfrom
xylar:ocn/fix-rrswisc6to18e3r5-moc-mask-filenamexylar/E3SM:ocn/fix-rrswisc6to18e3r5-moc-mask-filenameCopy head branch name to clipboard

Conversation

@xylar
Copy link
Copy Markdown
Contributor

@xylar xylar commented Mar 24, 2025 •
edited
Loading

This merge adds a unique datestamp to RRSwISC6to18E3r5 MOC mask file. Previously, the file had the datestamp associated with the geometry used to create the masks (which still needs to be retained, now with a suffix mg for mask geometry) but now it also has the creation date:

RRSwISC6to18E3r5_mocBasinsAndTransects20210623mg.20250205.nc

This merge also bumps the time stamp of the ocean and sea-ice initial conditions (before spin-up) because we had to convert the file from netcdf4 to cdf5 format and need to ensure that the cdf5 version is on all machines.

This was requested in #7159 and is one of two PRs toward fixing that problem.

@xylar xylar added MPAS-ocean Concerning the MPAS-ocean model coupled to E3SM. BFB PR leaves answers BFB labels Mar 24, 2025
@xylar xylar requested a review from jonbob March 24, 2025 19:17
@xylar xylar requested a review from rljacob March 24, 2025 19:36
@xylar
Add a unique datestamp to RRSwISC6to18E3r5 MOC mask file
52d2bf5 
Previously, the file had the datestamp associated with the geometry
used to create the masks (which still needs to be retained with suffix
`mg` for mask geometry) but now it also has the creation date:
```
RRSwISC6to18E3r5_mocBasinsAndTransects20210623mg.20250205.nc
```
@xylar xylar force-pushed the ocn/fix-rrswisc6to18e3r5-moc-mask-filename branch from b87a026 to 52d2bf5 Compare March 24, 2025 20:05
@xylar
Copy link
Copy Markdown
Contributor Author

xylar commented Mar 24, 2025

Thanks @rljacob. As I said I would in #7159, I made your suggested name change to add mg.

@xylar
Copy link
Copy Markdown
Contributor Author

xylar commented Mar 24, 2025

As an aside, I will update our Compass workflow to produce files with this naming convention going forward.

@xylar xylar requested a review from rljacob March 24, 2025 23:58
@xylar
Point cdf5 version of RRSwISC6to18E3r5 initial condition
b819923 
On 2025-02-05, we converted the old initial condition to cdf5
format but we neglected to bump the date stamp.  As a result,
the initial condition on various machines may still be the
netcdf4 version.  This merge bumps the datestamp to ensure that
the correct version is downloaded.
@xylar xylar force-pushed the ocn/fix-rrswisc6to18e3r5-moc-mask-filename branch from 038b8a5 to b819923 Compare March 25, 2025 00:04
@xylar xylar added the MPAS-seaice Concerning the MPAS-seaice model label Mar 25, 2025
@xylar
Copy link
Copy Markdown
Contributor Author

xylar commented Mar 25, 2025

@jonbob, do you want to do the same for the cpl file that was affected?

/lcrc/group/e3sm/data/inputdata/cpl/cpl6/map_r025_to_RRSwISC6to18E3r5_cstmnn.r50e100.20240328.nc

@xylar
Copy link
Copy Markdown
Contributor Author

xylar commented Mar 25, 2025

@rljacob, I've asked you to review again because I've made further changes but maybe hold off for @jonbob to review first.

@xylar xylar changed the title Add a unique datestamp to RRSwISC6to18E3r5 MOC mask file Bump datedstamp on several RRSwISC6to18E3r5 inputdata files Mar 25, 2025
@xylar xylar mentioned this pull request Mar 25, 2025
Merged
@xylar
Bump MOC mask datestamp once again
763e051 
Today's version of the mask file has no int64 fields anymore.  Even
the ones ont read in by the MPAS framework are caught by the
error check, so we just need to convert them all to int32.
@jonbob
Copy link
Copy Markdown
Contributor

jonbob commented Mar 25, 2025

@xylar -- I can do that with the cpl file as well. Is it OK to add to this PR?

@dqwu
Copy link
Copy Markdown
Contributor

dqwu commented Mar 25, 2025

@xylar I have tested this PR and there are a lot of log.seaice.xxx.err files in the run directory:
/lcrc/group/e3sm2/wuda/E3SMv3_dev/20250325.v3.1day.ne120.initial.chrysalis.debug.7165/run

Content of log.seaice.0000.err

----------------------------------------------------------------------
Beginning MPAS-seaice Error Log File for task       0 of    5120
    Opened at 2025/03/25 12:19:11
----------------------------------------------------------------------

CRITICAL ERROR: rescale_mesh: inconsistent radii: sphere_radius: 6371220.00000000, earthRadius: 6371229.00000000
Logging complete.  Closing file at 2025/03/25 12:19:11

@dqwu
Copy link
Copy Markdown
Contributor

dqwu commented Mar 25, 2025

@xylar I have tested this PR and there are a lot of log.seaice.xxx.err files in the run directory: /lcrc/group/e3sm2/wuda/E3SMv3_dev/20250325.v3.1day.ne120.initial.chrysalis.debug.7165/run

Content of log.seaice.0000.err

----------------------------------------------------------------------
Beginning MPAS-seaice Error Log File for task       0 of    5120
    Opened at 2025/03/25 12:19:11
----------------------------------------------------------------------

CRITICAL ERROR: rescale_mesh: inconsistent radii: sphere_radius: 6371220.00000000, earthRadius: 6371229.00000000
Logging complete.  Closing file at 2025/03/25 12:19:11

This issue is caused by the streams patch in the run script, which needs to be updated. I will test this PR with an updated run script.

@dqwu
Copy link
Copy Markdown
Contributor

dqwu commented Mar 25, 2025

@xylar I have tested this PR and there are a lot of log.seaice.xxx.err files in the run directory: /lcrc/group/e3sm2/wuda/E3SMv3_dev/20250325.v3.1day.ne120.initial.chrysalis.debug.7165/run
Content of log.seaice.0000.err

----------------------------------------------------------------------
Beginning MPAS-seaice Error Log File for task       0 of    5120
    Opened at 2025/03/25 12:19:11
----------------------------------------------------------------------

CRITICAL ERROR: rescale_mesh: inconsistent radii: sphere_radius: 6371220.00000000, earthRadius: 6371229.00000000
Logging complete.  Closing file at 2025/03/25 12:19:11

This issue is caused by the streams patch in the run script, which needs to be updated. I will test this PR with an updated run script.

@xylar FYI, no run time errors with the updated run script.

@xylar
Copy link
Copy Markdown
Contributor Author

xylar commented Mar 25, 2025

@xylar -- I can do that with the cpl file as well. Is it OK to add to this PR?

@jonbob, yes, please push to this PR.

@jonbob
Copy link
Copy Markdown
Contributor

jonbob commented Mar 26, 2025 •
edited
Loading

Successfully ran:

  • SMS_P3200x1_Ld1.ne120pg2_r025_RRSwISC6to18E3r5.WCYCL1850NS.chrysalis_intel

verified new files were found and used

jonbob
jonbob approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on testing and visual inspection

jonbob added a commit that referenced this pull request Mar 26, 2025
@jonbob
Merge branch 'xylar/ocn/fix-rrswisc6to18e3r5-moc-mask-filename' into …
c95ac60 
…next (PR #7165)

This merge adds a unique datestamp to RRSwISC6to18E3r5 MOC mask file.
Previously, the file had the datestamp associated with the geometry used
to create the masks (which still needs to be retained, now with a suffix
mg for mask geometry) but now it also has the creation date:
* RRSwISC6to18E3r5_mocBasinsAndTransects20210623mg.20250205.nc
This merge also bumps the time stamp of the ocean and sea-ice initial
conditions (before spin-up) because we had to convert the file from
netcdf4 to cdf5 format and need to ensure that the cdf5 version is on
all machines.

This was requested in #7159 and is one of two PRs toward fixing that
problem.

[BFB]
@jonbob
Copy link
Copy Markdown
Contributor

jonbob commented Mar 26, 2025

merged to next

@xylar
Copy link
Copy Markdown
Contributor Author

xylar commented Mar 26, 2025

Thanks @jonbob!

@xylar xylar mentioned this pull request Mar 26, 2025
Merged
1 task
@jonbob jonbob merged commit d945c9e into E3SM-Project:master Mar 27, 2025
7 checks passed
@jonbob
Copy link
Copy Markdown
Contributor

jonbob commented Mar 27, 2025

merged to master

@xylar xylar mentioned this pull request Jul 4, 2025
Merged
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rljacob rljacob rljacob approved these changes

@jonbob jonbob jonbob approved these changes

Assignees

@jonbob jonbob

Labels

BFB PR leaves answers BFB MPAS-ocean Concerning the MPAS-ocean model coupled to E3SM. MPAS-seaice Concerning the MPAS-seaice model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xylar @jonbob @dqwu @rljacob
Morty Proxy This is a proxified and sanitized view of the page, visit original site.