Refactor 1D tests to reduce repetitive code#81
Merged
JohnDN90 merged 2 commits intoMar 5, 2020
masterMASTmultiphysics/mast-multiphysics:masterfrom
refactor-1D-testsMASTmultiphysics/mast-multiphysics:refactor-1D-testsCopy head branch name to clipboard
Merged
Refactor 1D tests to reduce repetitive code#81JohnDN90 merged 2 commits intomasterMASTmultiphysics/mast-multiphysics:masterfrom refactor-1D-testsMASTmultiphysics/mast-multiphysics:refactor-1D-testsCopy head branch name to clipboard
JohnDN90 merged 2 commits into
masterMASTmultiphysics/mast-multiphysics:masterfrom
refactor-1D-testsMASTmultiphysics/mast-multiphysics:refactor-1D-testsCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors some of the Catch2 test code. It introduces some re-usable classes to define basic elements/storage that can be utilized as setup-code so similar storage doesn't need to be created for every test.
There is still a fair amount of replicated code, but it all generally appears inside of Catch
SECTIONSthat I believe we want to keep separate. Short of writing some macros for this, I'm not sure how we can avoid it at this time.In addition, this PR introduces the TEST namespace where these test helper classes and other test-methods can be stored. The Doxygen documentation has also been updated to parse the
testsdirectory so that these helper classes/functions can be documented. They are separated from library by being in a different namespace.@JohnDN90 can you look over this stuff and make sure I am still capturing the spirit of your tests.